Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603846 --- Comment #4 from Bastien Nocera <bnocera@xxxxxxxxxx> 2010-06-18 12:51:19 EDT --- (In reply to comment #2) <snip> > Should probably fix some of these: > > - nuke the rpaths > - ditch NEWS until there's news > - use -p for %post/%postun Done. (In reply to comment #3) > package name: OK > spec file name: OK > packaging guidelines: > - the initial rm in %install is no longer required Done. > - %clean is also no longer needed Done. > - since you are installing icons in hicolor, you should update the hicolor > icon cache in %posttrans/%postun Done. > directory ownership: > - must own %(_libdir}/libpeas-1.0 and %{_libdir}/libpeas-1.0/loaders Done. > - must either own %{_libdir}/girepository-1.0 or require gobject-introspection Already does: 18 # For the girepository-1.0 directory• 19 Requires:↦ gobject-introspection• > - same for %{_datadir}/gir-1.0 Already does too: 30 Requires:↦ gobject-introspection-devel• All in: http://people.fedoraproject.org/~hadess/libpeas/libpeas-0.5.0-3.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review