Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libopm - Blitzed open proxy monitor library Alias: libopm https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212894 ------- Additional Comments From chris.stone@xxxxxxxxx 2006-11-05 16:50 EST ------- ======== REVIEW CHECKLIST ======== - rpmlint output clean - package named according to package naming guidelines - spec filename matches package name - package meets packaging guidelines - package licensed with opensource compatible license - license in spec matches actual license - license in %doc - spec file written in American English - spec file is legible X SOURCE FILES DO NOT MATCH - package successfully compiles and builds on FC5 x86_64 - no build dependencies required - no locales required - %post and %postun properly run ldconfig - package is not relocatable - package owns all directories it creates - no duplicate files in %files - permissions are set properly - spec file contains proper %clean section - macro usage is consistent - package contains code - no large documentation files - files in %doc do not affect runtime - header files are in devel subpackage - no pkgconfig used - .so file in devel - devel package requires base package - package does not contain .la file - not a GUI app, no .desktop file needed - package does not own files or directories owned by other pacakges ======== MUST FIX ======== X SOURCES DO NOT MATCH - 5537327b4e76bd2c5074996b16cad361 ../SOURCES/libopm-0.1.tar.gz - c3da807c0d90cc89c301d83ac5669238 cvs/libopm-0.1.tar.gz - Please provide specific tar instruction used, I don't want to check the md5sum of each source file individually. I believe the difference is caused by the order of the files in the tarball. The command I used to tar the source files was: tar czf libopm-0.1.tar.gz libopm-0.1/ - In addition, your cvs co command should include a specific date so that if something is added to the cvs in the future, someone can still pull the exact sources used in this package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review