Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603514 --- Comment #1 from Ian Weller <ian@xxxxxxxxxxxxx> 2010-06-18 10:29:06 EDT --- [ OK ] specfiles match: 950b547a9132a37e853b8db64cae1d39 libmodman.spec 950b547a9132a37e853b8db64cae1d39 libmodman.spec.1 [ OK ] source files match upstream: 05213b381858c9c0fdf71309ada81ea3 libmodman-1.0.1.tar.gz 05213b381858c9c0fdf71309ada81ea3 libmodman-1.0.1.tar.gz.1 [ OK ] package meets naming and versioning guidelines. [ OK ] spec is properly named, cleanly written, and uses macros consistently. [ OK ] dist tag is present. [ OK ] build root is correct. [ OK ] license field matches the actual license. [ OK ] license is open source-compatible. [ OK ] license text included in package. [ OK ] latest version is being packaged. [FAILED] BuildRequires are proper. build.log attached [ OK ] compiler flags are appropriate. [ OK ] %clean is present. [FAILED] package builds in mock. build.log attached [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [ OK ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ OK ] documentation is small, so no -docs subpackage is necessary. [ OK ] %docs are not necessary for the proper functioning of the package. [ N/A ] desktop files valid and installed properly. Items that will be checked after package builds in mock: [ ] package installs properly. [ ] debuginfo package looks complete. [ ] rpmlint is silent. [ ] final provides and requires are sane [ ] %check is present and all tests pass [ ] no shared libraries are added to the regular linker search paths. [ ] owns the directories it creates. [ ] doesn't own any directories it shouldn't. [ ] no headers. [ ] no pkgconfig files. [ ] no libtool .la droppings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review