Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603269 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #5 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-06-16 10:20:23 EDT --- For -2: * For plist.patch - As this is a patch, please use "Patch0" instead of "Source1" - And please consider to rename this to something which indicates what this patch is for, and also write some comments about this patch briefly. * Comments in %check - Please remove comments which are no longer needed ( ruby test or so is no longer needed ) * Fallback in %check - I don't think "|| :" after rake test is needed any longer. * %doc in -doc - Well, I don't think you have to add %doc in -doc just to suppress rpmlint warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review