Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570017 Kalev Lember <kalev@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #8 from Kalev Lember <kalev@xxxxxxxxxxxx> 2010-06-15 21:25:56 EDT --- (In reply to comment #6) > * Tue Jun 8 2010 <Laurent.Rineau__fedora@xxxxxxxxxxxxxx> - 0-0.6.20100304gitec01dd42 Sorry for picking on the changelog format so much, but it's supposed to be * date name <email> - version You are missing the name. > - Patch0 for F-13: link explicitly with zlib. Did you submit the patch for upstream inclusion too? > I prefer not to use globbing to much, to avoid surprises when I update the spec > file with a new upstream version. Is it required by the guidelines to minimize > the size of %file? Certainly not, it's up to you to use globbing if you think it makes your life easier. > Anyway, %{_kde4_docdir}/HTML/en/k4dirstat/ must be owned, and my previous %file > did not own it. {_kde4_appsdir}/k4dirstat/ isn't owned either. > I have added such a comment. Strangely, the md5sum of the tarball has changed, > but not its content. Maybe I used non-default compression level for gzip in > March. As long as there is a way to regenerate tarball's content, it's all good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review