Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578480 --- Comment #38 from Michal Schmidt <mschmidt@xxxxxxxxxx> 2010-06-15 14:52:10 EDT --- Formal review of spectrum-0.3-0.7.git20100614: Summary ------- Do not forget to maintain changelogs. Fix Requires (add some for %preun, remove some for %pre). Use %global instead of %define. Preserve timestamps where possible. Add BuildRequires: python2-devel Details ------- MUST items from the Review Guidelines: OK rpmlint must be run on every package. The output should be posted in the review. OK The package must be named according to the Package Naming Guidelines. OK The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK The License field in the package spec file must match the actual license. OK If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK The spec file must be written in American English. OK The spec file for the package MUST be legible. OK The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. OK The package MUST successfully compile and build into binary rpms on at least one primary architecture. TODO If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. OK All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines; inclusion of those as BuildRequires is optional. Apply common sense. N/A The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. N/A Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. OK Packages must NOT bundle copies of system libraries. N/A If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. OK A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK A Fedora package must not list a file more than once in the spec file's %files listings. OK Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. OK Each package must consistently use macros. OK The package must contain code, or permissable content. N/A Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). OK If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. N/A Header files must be in a -devel package. N/A Static libraries must be in a -static package. N/A If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. N/A In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} OK Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. N/A Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. OK Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. OK All filenames in rpm packages must be valid UTF-8. Packaging Guidelines: OK Naming OK Version and Release OK Legal OK Spec Legibility TODO Architecture Support (the submitter promised to file a bug for excluding ppc as soon as the component is created in BZ) OK Filesystem Layout OK Use rpmlint BAD Changelogs (the latest entry is not in sync with Release) OK Tags OK Buildroot OK %clean BAD Requires (missing Requires(preun), and Requires(pre) contain too much) OK BuildRequires OK Summary and Description OK Encoding OK Documentation OK Compiler Flags OK Debuginfo Packages N/A Devel Packages N/A Shared Libraries OK Duplication of System Libraries OK Beware of Rpath OK Configuration Files OK Initscripts N/A Desktop Files BAD Macros (please use %global instead of %define) N/A Locale Files BAD Timestamps (please add "-p" to install invocations where appropriate) OK Parallel make OK Scriptlets N/A Conditional Dependencies OK Relocatable Packages OK Code vs. Content OK File and Directory Ownership OK Users and Groups N/A Web Applications OK Conflicts OK No External Kernel Modules OK No Files or Directories under /srv OK No Bundling of Multiple Projects N/A Patches Should Have an Upstream Bug Link or Comment OK Use of Epochs N/A Symlinks OK Man Pages Packaging:Python: BAD BuildRequires (missing python2-devel) OK Macros OK Files to Include OK Source Files OK Byte Compiling N/A various stuff about co-existence of v2 and v3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review