Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600270 Ian Weller <ian@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Ian Weller <ian@xxxxxxxxxxxxx> 2010-06-14 23:44:03 EDT --- [ OK ] specfiles match: 4f87fa3cd37d119339d4f899120ed76a libnmserver.spec 4f87fa3cd37d119339d4f899120ed76a libnmserver.spec.1 [ OK ] source files match upstream: 3bf81b09bf6dd26f4187b6d7af2193b0 libnmserver-0.0.90.tar.gz 3bf81b09bf6dd26f4187b6d7af2193b0 libnmserver-0.0.90.tar.gz.1 [ OK ] package meets naming and versioning guidelines. [ OK ] spec is properly named, cleanly written, and uses macros consistently. [ OK ] dist tag is present. [ OK ] build root is correct. [ OK ] license field matches the actual license. [ OK ] license is open source-compatible. [FAILED] license text included in package. This isn't a blocker, but please ask upstream to include a COPYING file, then include it in %doc in a future specfile. [ OK ] latest version is being packaged. [ OK ] BuildRequires are proper. [ OK ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock. [ OK ] package installs properly. [ OK ] debuginfo package looks complete. [FAILED] rpmlint is silent. libnmserver.x86_64: W: no-documentation libnmserver-devel.x86_64: W: no-documentation (once again not a blocker, see "license text included in package") [ OK ] final provides and requires are sane [ N/A ] %check is present and all tests pass: [ OK ] shared libraries aren't added to linker search paths without ldconfig. [ OK ] owns the directories it creates. [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [ OK ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ OK ] documentation is small, so no -docs subpackage is necessary. [ N/A ] %docs are not necessary for the proper functioning of the package. [ OK ] headers in devel subpackage. [ OK ] pkgconfig files in devel subpackage. [ OK ] no libtool .la droppings. [ N/A ] desktop files valid and installed properly. ---------------------------------------- This package (libnmserver) is APPROVED ---------------------------------------- Please be sure to contact upstream to add a COPYING file, then add that to %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review