Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=602574 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-06-14 10:37:51 EDT --- Hi Jeremy, here are some initial comments: - according to file README, the license is GPLv3+, not GPLv3 only - to simplify things, I suggest to replace the rm and rmdir line with rm -rf %{buildroot}/usr/share/doc/ - remove "%doc" from "%doc %{_mandir}/man1/patchelf.1*" - don't mix tabs and spaces for indentation - The tarball contains a couple of tests. It's probably a good idea to run them (with "make check" in a %check section). $ rpmlint /var/lib/mock/fedora-13-i386/result/*.rpm patchelf.i686: W: spelling-error %description -l en_US executables -> executable, executable s, executrices patchelf.src: W: spelling-error %description -l en_US executables -> executable, executable s, executrices patchelf.src: W: no-buildroot-tag patchelf.src:10: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 10) 3 packages and 0 specfiles checked; 0 errors, 4 warnings. The missing buildroot tag can be ignored if you plan to maintain this package for Fedora only. Otherwise, you should add one and also clean the buildroot in %install. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review