Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603295 --- Comment #2 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2010-06-14 04:32:43 EDT --- I planned to start official review immediately, but due to problems with this package noted below I will delay it until those issues are fixed. NEEDSWORK: rpmlint must be run on every package. The output should be posted in the review. guava.src: W: name-repeated-in-summary C Guava guava.src: W: spelling-error %description -l en_US google's -> Google's, goggle's, go ogle's guava.src: W: spelling-error %description -l en_US io -> oi, Io, ii guava.src: W: spelling-error %description -l en_US javax -> java, java x, Java guava.src: W: invalid-url Source0: guava-r05.tar.bz2 guava.noarch: W: name-repeated-in-summary C Guava guava.noarch: W: spelling-error %description -l en_US google's -> Google's, goggle's, go ogle's guava.noarch: W: spelling-error %description -l en_US io -> oi, Io, ii guava.noarch: W: spelling-error %description -l en_US javax -> java, java x, Java guava.noarch: W: non-conffile-in-etc /etc/maven/fragments/guava guava.noarch: W: dangling-relative-symlink /usr/share/java/guava-r05.jar *-05* 3 packages and 0 specfiles checked; 0 errors, 11 warnings. So let's go 1 by 1: - summary should normally not repeat name of package. So simplify it to something like "Google Core Libraries for Java" - "Google's" not "google's" - your symlink in /usr/share/java is completely wrong. You will have to play with it a bit. BIG FAT WARNING: I have noted this before in previous reviews (not sure if it was your package). When you do: > svn export http://guava-libraries.googlecode.com/svn/trunk/ guava-r05 You CAN NOT guarantee checked out sources will always be the same! In fact checked out sources are very different from sources you'd get by doing: > svn export http://guava-libraries.googlecode.com/svn/tags/release05 guava-r05 And that you should do. Trunk is always changing, so you cannot make releases out of it without specifying at least revision number (if no tags exist). NEEDSWORK: The package must meet the Packaging Guidelines . Don't use: > ln -s /usr/share/java/jsr-305.jar lib/jsr305.jar Instead use something like export CLASSPATH=$(build-classpath jsr-305) or if the build system really needs that jar file in lib/, see: https://fedoraproject.org/wiki/Packaging:Java#build-jar-repository I'll do full official review after these problems have been fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review