Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=601633 --- Comment #9 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-06-13 14:35:16 EDT --- Some notes: * Naming - As this is based on sup "gem", please name rpm as "rubygem-sup" anyway (because installed rpm can be used as sup "gem"). * Explicit version dependency - Usually when a package depends on an other package with specific dependency, if the (latter) package on Fedora satisfies the version dependency on all supported branches, we regards it jus redundant to write such version dependency explicitly. - For example rubygem-mime-types when Fedora 12 is released has EVR "1.16-3.fc11", so we regard writing ">= 1" dependency on "Requires: rubygem(mime-types)" is just redundant Note that this package can be imported on Fedora 12 and above (we cannot add new package on Fedora 11 anymore) * %gemdir/bin scripts treatment - We usually * move files under %gemdir/bin to %_bindir * then just do "rmdir %buildroot/%gemdir" * and don't move files under %geminstdir/bin As you actually modified gemspec file, it should be that scripts under %gemdir/bin can correctly be used ! and anyway "$ ruby -rubygems -e 'gem "sup"' " should succeed. * ncurses dependency - This package installs %geminstdir/lib/ncurses.rb - I don't think this file is needed because ruby-ncurses rpm is to be installed. - Also this file contains ------------------------------------------------------------------ 21 require "ncurses.so" ------------------------------------------------------------------ however ncurses.so cannot be found (note that ruby-ncurses contains %ruby_sitearch/ncurses_bin.so) So please remove this file to avoid confusion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review