Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603366 --- Comment #2 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> 2010-06-12 15:48:08 EDT --- Thanks very much Thomas, comments below. New spec and srpm: Spec URL: http://jgu.fedorapeople.org/coan.spec SRPM URL: http://jgu.fedorapeople.org/coan-4.1-2.fc13.src.rpm (In reply to comment #1) > Needswork: > - %files: please use %{_mandir}/man1/%{name}.1.*, so the man pages compression > can change at will. Done. > - second paragraph in description is still "Sunifdef". Needs to be %{name} > Fixed. > - please use INSTALL="install -p" when installing Done. > - the first few lines would be more readable, when name, version etc would be > properly aligned... Done. > - removing of the excecutable bit on *.c and *.h and the for loop in %prep are > not needed anymore OK, removed. > - rpmlint: > $ rpmlint ./coan-4.1-1.fc13.src.rpm ./x86_64/coan-* > coan.src: W: spelling-error Summary(en_US) preprocessor -> processor, > teleprocessing, processional Changed to pre-processor > coan.src: W: spelling-error %description -l en_US sunifdef -> sundries, > sunshade, Sunnite Ignored. > coan.src: W: spelling-error %description -l en_US analysing -> analyzing, > analysis, analysand Fixed (heh, both me and the upstream author are from the UK, and that was a copy and paste from the web page). > coan.src: W: spelling-error %description -l en_US preprocessor -> processor, > teleprocessing, processional Changed to pre-processor > coan.src: W: spelling-error %description -l en_US Sunifdef -> Sundries, > Sunshade, Sunnite Replaced with %{name} > coan.src: W: spelling-error %description -l en_US ifdef -> if def, if-def, > infidel Ignored. > coan.src: W: no-cleaning-of-buildroot %install > coan.src: W: no-cleaning-of-buildroot %clean > coan.src: W: no-buildroot-tag > coan.src: W: no-%clean-section These are no longer needed -> ignored. > coan.x86_64: W: spelling-error Summary(en_US) preprocessor -> processor, > teleprocessing, processional Changed to pre-processor > coan.x86_64: W: spelling-error %description -l en_US sunifdef -> sundries, > sunshade, Sunnite Replaced with %{name} > coan.x86_64: W: spelling-error %description -l en_US analysing -> analyzing, > analysis, analysand Fixed. > coan.x86_64: W: spelling-error %description -l en_US preprocessor -> processor, > teleprocessing, processional Replaced with pre-processor > coan.x86_64: W: spelling-error %description -l en_US Sunifdef -> Sundries, > Sunshade, Sunnite Replaced with %{name} > coan.x86_64: W: spelling-error %description -l en_US ifdef -> if def, if-def, > infidel Ignored. > 3 packages and 0 specfiles checked; 0 errors, 16 warnings. > > ** analysing -> analyzing is a spelling error, the rest is ignorable on a > recent fedora version. > > > ############################################################################### > > The man pages compression and description change is a MUST, the other SHOULDS. > Approving, when the first two have changed (I bet you will ;)). Yup, done. > > ############################################################################### > > APPROVED Cheers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review