Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=602597 --- Comment #2 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-06-11 22:24:54 EDT --- Thanks for packaging this :) The package looks good; the following are suggestions, not blockers. DESTDIR seems to be a safer choice than PERL_INSTALL_ROOT given the recent fun around it. Please consider using %{?perl_default_filter}; it won't harm anything and it will make sure unwanted deps don't creep in down the road. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2246047 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Latest version (0.03) is being packaged. Source tarballs match upstream (sha1sum): a87c92d4706a93d3fe6c4227667ab3ac188879b3 Package-Stash-0.03.tar.gz a87c92d4706a93d3fe6c4227667ab3ac188879b3 Package-Stash-0.03.tar.gz.srpm Final provides / requires are sane: ====> rpmlint perl-Package-Stash.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. ======> perl-Package-Stash-0.03-1.fc14.noarch.rpm <====== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides perl(Package::Stash) = 0.03 perl-Package-Stash = 0.03-1.fc14 ====> requires perl(:MODULE_COMPAT_5.10.1) perl(Carp) perl(Scalar::Util) perl(strict) perl(warnings) ====> obsoletes ====> conflicts ======> perl-Package-Stash-0.03-1.fc14.src.rpm <====== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides ====> requires perl(ExtUtils::MakeMaker) perl(Pod::Coverage::TrustPod) perl(Scalar::Util) perl(Test::Exception) perl(Test::More) perl(Test::Pod) perl(Test::Pod::Coverage) ====> obsoletes ====> conflicts APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review