Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478613 --- Comment #17 from Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> 2010-06-11 17:50:24 EDT --- Some minor issues need fixing; see below for details #+TODO: TODO(t) WAIT(w@/!) FAIL(f@) | DONE(d) N/A(n) * TODO Review [44%] ** DONE Names [2/2] *** DONE Package name *** DONE Spec name ** DONE Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] ** FAIL source files match upstream - State "FAIL" from "TODO" [2010-06-11 Fri 22:51] \\ Bundled tgz's MD5 matches upstream, however the URL listed is wrong 2.6.2 is only available from GitHub, not SF: http://github.com/downloads/jwiegley/ledger/ledger-2.6.2.tar.gz ** DONE License [3/3] *** DONE License is Fedora-approved BSD *** DONE License field accurate *** DONE License included iff packaged by upstream ** TODO rpmlint [0/2] *** FAIL on src.rpm - State "FAIL" from "TODO" [2010-06-11 Fri 23:18] \\ $ rpmlint ./ledger-2.6.2-3.fc13.src.rpm ledger.src:92: E: files-attr-not-set ledger.src:95: E: files-attr-not-set ledger.src: W: invalid-url Source0: http://downloads.sourceforge.net/ledger/ledger-2.6.2.tar.gz HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 2 errors, 1 warnings. Each subpackage needs a %defattr line *** WAIT on x86_64.rpm - State "WAIT" from "TODO" [2010-06-11 Fri 23:45] \\ $ rpmlint ~/Downloads/*ledger*.rpm emacs-common-ledger.x86_64: W: no-documentation emacs-common-ledger-el.x86_64: W: spelling-error Summary(en_US) elisp -> lisp, e lisp, Elise emacs-common-ledger-el.x86_64: W: spelling-error %description -l en_US elisp -> lisp, e lisp, Elise emacs-common-ledger-el.x86_64: W: no-documentation ledger.x86_64: W: incoherent-version-in-changelog 2.6.1-1 ['2.6.2-3.fc13', '2.6.2-3'] ledger-devel.x86_64: W: spelling-error %description -l en_US libamounts -> lib amounts, lib-amounts, amounts ledger-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 7 warnings. - ChangeLog needs updating - Spelling errors can be ignored - Documentation warning can be ignored ** DONE Language & locale [3/3] *** DONE Spec in US English *** DONE Spec legible *** N/A Use %find_lang to handle locale files ** TODO Build [2/3] *** DONE Koji results http://koji.fedoraproject.org/koji/taskinfo?taskID=2245711 *** DONE BRs complete *** TODO Directory ownership ** TODO Spec inspection *** DONE ldconfig for libraries *** TODO No duplicate files *** TODO File permissions *** TODO Filenames must be UTF-8 *** DONE Has %clean section (except F-13+: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) *** TODO %buildroot cleaned on %install *** DONE Macro usage consistent *** TODO Documentation **** TODO If large docs, separate -doc **** TODO %doc files are non-essential *** DONE Development [4/4] **** DONE Headers in -devel **** DONE If versioned .so's, unversioned in -devel **** DONE -devel requires main **** DONE No .la *** FAIL Other subpackages - State "FAIL" from "" [2010-06-11 Fri 23:44] \\ Emacs packaging: emacs-common-ledger and emacs-common-ledger-el should be swapped: -el for source files, not for byte-compiled files https://fedoraproject.org/wiki/Packaging:Emacs#Package_naming_and_sub-package_organization On F-11+ (all the versions still supported), RPM supports noarch subpackages. You might want to make the Emacs subpackages noarch https://fedoraproject.org/wiki/Packaging:Emacs#Use_of_BuildArch:_noarch ** TODO [[http://fedoraproject.org/wiki/Packaging/ScriptletSnippets][Scriptlets]] *** FAIL info files - State "FAIL" from "TODO" [2010-06-11 Fri 23:29] \\ Minor issue: probably should Requires(post) and Requires(preun) the info package rather than the /sbin/install-info binary -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review