Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=601160 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #7 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-06-11 13:53:44 EDT --- For -3: * Unneeded macro - %ruby_sitelib macro is used nowhere. * Dependency for -doc subpackage - As I said in the previous comment, for directory (%geminstdir) ownership issue, -doc subpackage should have the dependency for main package ( i.e. -doc subpackage should have "R: %{name} = %{version}-%{release} ) * .gemspec - Move %{geminstdir}/rdiscount.gemspec to -doc subpackage. This one is needed only for tests. ( %{gemdir}/specifications/%{gemname}-%{version}.gemspec should stay in main package ). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review