Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600638 --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-06-11 12:10:07 EDT --- Created an attachment (id=423325) --> (https://bugzilla.redhat.com/attachment.cgi?id=423325) mock log for rawhide Some notes: ! Latest version - The latest version seems 2.31.0, however for now I will review 2.30.0 because you probably import stable version into F-13. * Cleanups - For BuildRoot, %clean section, please check my comment on bug 600637. * BR - Your srpm won't build without additional "BR: intltool dbus-glib-devel". Plase see attached. * rpath - As written in https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath use rpath "as a last resort" (i.e. avoid using rpath as much as possible). ! Note - Usually the reason that unneeded rpath /usr/lib64 is added to the rebuilt binary is that the upstream developer uses libtool which does not take special care of /usr/lib64 for sys_lib_dlsearch_path_spec, while Fedora's libtool take care of this by adding a patch. See the below patch: http://cvs.fedoraproject.org/viewvc/rpms/libtool/devel/libtool-2.2.6a-rpath.patch?content-type=text%2Fplain&view=co So actually for most cases, the case that rpath /usr/lib64 is added (only for 64 bits arch) can be avoided by ------------------------------------------------------------------------ sed -i.libdir_syssearch -e \ '/sys_lib_dlsearch_path_spec/s|/usr/lib |/usr/lib /usr/lib64 /lib /lib64 |' \ configure ------------------------------------------------------------------------ i.e. just add the needed paths to sys_lib_dlsearch_path_spec in configure (note that libtool in the build directory is generated by configure) before calling %configure. - You can alternatively do "autoreconf -fi", however calling autotools is not recommended unless unavoidable. * Make build.log more verbosely - Currently build logs for linkage or so are suppressed. Please add "V=1" to "make %{?_smp_mflags}" to show more verbose log. * Cflags - Fedora specific compilation flags are not honored correctly. https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags configure{,ac} shows that environ-specified CFLAGS is replaced. For this package this can be fixed by below, for example: ------------------------------------------------------------------------ sed -i.cflags -e \ 's|^\([ \t][ \t]*\)CFLAGS="[^\$].*$|\1true|' \ configure ------------------------------------------------------------------------ * Timestamps - As I wrote in bug 600637, please consider to keep timestamps on installed files as much as possible with ------------------------------------------------------------------------ make install DESTDIR=$RPM_BUILD_ROOT DESTDIR="install -p" ------------------------------------------------------------------------ This method usually works for makefiles generated by recent autotools. * %doc in -doc subpackage - Usually I think %doc attribute in -doc subpackage is just redundant because the rpm name already said it is for documentation ! Note that the files / etc under %_datadir/gtk-doc is automatically marked as %doc, so explicit %doc for %{_datadir}/gtk-doc/html/seed is anyway redundant. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review