Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593851 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |martin.gieseking@xxxxxx Flag| |fedora-review+ --- Comment #6 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-06-11 11:36:59 EDT --- Hi Richard, here's the formal review of clide. The package looks fine now, so we can finish here. $ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. --------------------------------- keys used in following checklist: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. - GPLv3+ [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum clide-0.9.tar.gz* f578b8c5f1b7f81c7280fcb549ca93c8 clide-0.9.tar.gz f578b8c5f1b7f81c7280fcb549ca93c8 clide-0.9.tar.gz.1 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - noarch package builds fine [.] MUST: If the package does not successfully compile, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. - no locales [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix ... [.] MUST: devel packages must require the base package ... [+] MUST: Packages must NOT contain any .la libtool archives [.] MUST: Packages containing GUI applications must include a %{name}.desktop file - no GUI [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) ... [+] SHOULD: The reviewer should test that the package builds in mock. - builds in mock [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. - noarch package [+] SHOULD: The reviewer should test that the package functions as described. - seems to work as expected [.] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [+] SHOULD: your package should contain man pages for binaries/scripts. ---------------- Package APPROVED ---------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review