Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563376 --- Comment #4 from Robin Lee <robinlee.sysu@xxxxxxxxx> 2010-06-11 11:05:53 EDT --- This is an old package and the spec file is well-structured. But it failed to build a binary package: https://koji.fedoraproject.org/koji/taskinfo?taskID=2244897 The %configure command should be something like: %configure --enable-libnotify \ --enable-wget \ --enable-iplookup \ --enable-proxy %{?_with_plugin:--enable-plugin} The fact that the plugin is disabled should be recorded in %changelog . And please change the release number every time you modify your spec file. And some comments should be added on why the plugin is disabled but the building code remains in the spec file. Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig The above lines are not necessary. Though the plugin is now prevented from building, the naming of it is not good. Maybe 'mozilla-pcmanx' is better, with respect to existing similar packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review