Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dar - Collection of scripts for making/restoring CD/DVD backups https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210790 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-11-04 09:19 EST ------- Okay, first full review of this package (dar). Almost okay. 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * rpmlint rpmlint is not silent. W: dar file-not-utf8 /usr/share/man/man1/dar.1.gz dar.1.gz contains ISO-8859-1 character (around the line 341). -------------------------------------------------------------------- This allows one to merge two archive in a single one. See also -$, -<THIS CHARACTER> and -% for other options concerning auxiliary archive of reference -------------------------------------------------------------------- Please change this character MANUALLY (iconv does not work for this case as this character seems to be tilde, while iconv tries to change this character to English pound character. * Requires: - For libdar-devel Usually the dependency for main package (for this package, it is libdar) is release-specific. i.e. Requires: libdar = %{version}-%{release} - Provides like Provides: libdar = %{version}-%{release} are all unnecessary as rpm always provides these implicitly. * BuildRequires: - Redundant BuildRequires is found. * zlib-devel <- this is required by openssl-devel 2. http://fedoraproject.org/wiki/Packaging/ReviewGuidelines = Nothing. 3. Other things I have noticed: * README.Fedora - Okay, this document is very preferable. Also I recommend you add your name and the date when you wrote this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review