Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600637 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-06-10 16:58:39 EDT --- Well, as some Japanese people said that it was said that his favorite "Same Gnome" disappeared, I will review this... Simple package. Some notes * noarch handling ---------------------------------------------------- %patch1 -p1 -b .license %build # not using standard configure macro. Nothing is compiled, # only prefix needed ./configure --prefix %{_prefix} ---------------------------------------------------- - Why don't you just use the following? ---------------------------------------------------- %configure --libdir=%{_datadir} ---------------------------------------------------- * Timestamps - Trying to keep timestamps on installed files is appreciated especially because this is based on recent autotools method and this is noarch. Please consider to use below: ---------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ---------------------------------------------------- * Cleanups - rpmlint may complain, however: * On Fedora BuildRoot tag is no longer used: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * On Fedora 13+, %clean is not needed: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean And I guess you need this package only for F-13+. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review