Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sparse - source code semantec parser used by the Linux kernel https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212513 jwboyer@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From jwboyer@xxxxxxxxxxxxxxxxxx 2006-11-03 22:18 EST ------- GOOD ==== * Package and spec named appropriately: See note below * Spec file is legible and in Am. English * Source matches upstream: See note below * No unnecessary BuildRequires * No locales * No shared libraries in the default linker path * RPM_BUILD_ROOT cleaned where appropriate * Not relocatable * No duplicate %files * File permissions look ok * No need for a -devel subpackage * Not a gui program; no need for a .desktop file * Consistent use of macros * Does not own any directories that it should not own. Note: I've sent an email to the upstream developers discussing a possible official release. If that comes to pass, we can use those for this package. Until then, git or tarball snapshots will work just fine. This package builds fine on ppc. This passes review. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review