Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598299 Adel Gadllah <adel.gadllah@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #22 from Adel Gadllah <adel.gadllah@xxxxxxxxx> 2010-06-10 16:07:42 EDT --- (In reply to comment #21) > I haven't removed the macros from comments since I don't want to be hardcoding > the values and adjusting them every bump. Just silenced it. Should be a > temporary thing till the point we switch over to releases. Yeah got that; another option would be to just escape them (%% instead of %). > http://sundaram.fedorapeople.org/packages/systemd.spec > http://sundaram.fedorapeople.org/packages/systemd-0-0.3.20100610git2f198e.fc13.src.rpm Looks good, I have not actually tried to run it as it is known broken but the spec is clean now and it builds fine. => Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review