Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542990 Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |602791 --- Comment #20 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> 2010-06-10 15:17:56 EDT --- (In reply to comment #18) > For the root-xrootd package it's using net/xrootd/src/xrootd/* ? > I think http://xrootd.slac.stanford.edu/ as an upstream should possibly > be a separate package instead. OK, makes sense. Review for xrootd submitted - bug 602791. (In reply to comment #19) > Hi, src/tmva looks to be both used and is BSD. > > With http://tmva.sourceforge.net/ as up stream. I have added a License tag to the root-tmva package. I consider this to be different from a bundled dependency. It is rather an external module that is merged with the main distribution. This is similar to other frameworks such as perl, where some external modules are distributed as part of the main perl package. > Generally there is quite a bit of code from other places, some of this > is not being used for sure such as > > core/pcre/src/pcre-7.8.tar.gz > > so while not a requirement to remove these kind of things it would certainly > make the review easier if this unused stuff could be removed in %setup > or even earlier. In the new specfile I remove all the unused bundled sources. http://www.grid.tsl.uu.se/review/root-5.26.00b-3.fc12.src.rpm http://www.grid.tsl.uu.se/review/root.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review