Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=602587 Paul Howarth <paul@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ --- Comment #6 from Paul Howarth <paul@xxxxxxxxxxxx> 2010-06-10 11:10:19 EDT --- Review Checklist: - rpmlint OK - package and spec file naming OK - package meets guidelines - license is same as perl, whcih is OK for Fedora - package license tag is correct: GPL+ or Artistic - no license text file to include - spec file is legible and written in English - source matches upstream - package builds OK in mock for rawhide x86_64 - buildreqs OK - no locale data to include - no shared or static libraries included - package not intended to be relocatable - directory owndership is OK - no duplicate files - %defattr(...) present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no subpackages - not a GUI app so no desktop file needed - filenames are all ASCII - no scriptlets - requires and provides are OK - manpage provided Source SHA-256 hashes: 7c21f9c8c2d0c0f0f0f46e77de7c3d879dd562668ddf0525875c38cef2076fd0 Upstream IPC-Signal-1.00.tar.gz 7c21f9c8c2d0c0f0f0f46e77de7c3d879dd562668ddf0525875c38cef2076fd0 Package IPC-Signal-1.00.tar.gz Test suite: $ make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/signal.t .. ok All tests successful. Files=1, Tests=7, 0 wallclock secs ( 0.02 usr + 0.00 sys = 0.02 CPU) Result: PASS Provides: perl(IPC::Signal) = 1.00 perl-IPC-signal = 1.00-3.fc14 Requires: perl(:MODULE_COMPAT_5.10.1) rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(VersionedDependencies) <= 3.0.3-1 perl >= 0:5.003_94 perl(Exporter) perl(strict) perl(vars) rpmlib(VersionedDependencies) <= 3.0.3-1 rpmlib(PayloadIsXz) <= 5.2-1 rpmlint: perl-IPC-signal.noarch: W: spelling-error %description -l en_US versa -> avers, verse, verso perl-IPC-signal.src: W: spelling-error %description -l en_US versa -> avers, verse, verso 2 packages and 0 specfiles checked; 0 errors, 2 warnings. CPAN RT: One outstanding issue, which is a feature request rather than a bug. https://rt.cpan.org/Public/Bug/Display.html?id=11464 Nits: - please maintain the timestamp of the upstream tarball (use wget or spectool to download it - it's dated 1998!) - a better URL for the upstream project would be: http://search.cpan.org/dist/IPC-Signal/ since it's not version or author specific Nothing to worry about then. The nits aren't blockers but you might fix them anyway. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review