Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596449 --- Comment #21 from Avesh Agarwal <avagarwa@xxxxxxxxxx> 2010-06-09 16:01:24 EDT --- (In reply to comment #20) > Rpm building fails on koji. I think you should remove the icon file, because > you don't include a desktop file in rpm, also other NM plugins already remove > icons and desktop files recently. > > error: Installed (but unpackaged) file(s) found: > > /usr/share/icons/hicolor/48x48/apps/gnome-mime-application-x-openswan-ipsec-vpn-settings.png > Fixed. > > > formal review here: > +:ok, =:needs attention, -:needs fixing > > MUST Items: > [-] MUST: rpmlint must be run on every package. > rpmlint NetworkManager-openswan.spec > NetworkManager-openswan.spec:31: W: mixed-use-of-spaces-and-tabs (spaces: line > 7, tab: line 31) > > rpmlint NetworkManager-openswan-*rpm > NetworkManager-openswan.x86_64: I: enchant-dictionary-not-found en_US > NetworkManager-openswan.x86_64: W: incoherent-version-in-changelog 0.8.0-1 > ['0.8.0-1.git20100411.fc14', '0.8.0-1.git20100411'] > NetworkManager-openswan.x86_64: W: non-conffile-in-etc > /etc/NetworkManager/VPN/nm-openswan-service.name > NetworkManager-openswan.x86_64: W: non-conffile-in-etc > /etc/dbus-1/system.d/nm-openswan-service.conf > Fixed all rpmlint errors. > [-] MUST: The package must be named according to the Package Naming Guidelines. Fixed. > Issues: > > 1. Most of the rpmlist warnings are harmless. > You should fix > NetworkManager-openswan.spec:31: W: mixed-use-of-spaces-and-tabs (spaces: line > 7, tab: line 31) > > NetworkManager-openswan.x86_64: W: incoherent-version-in-changelog 0.8.0-1 > ['0.8.0-1.git20100411.fc14', '0.8.0-1.git20100411'] > Fixed. > > 2.According to naming guideline %define snapshot .git20100411 should be %define > snapshot .20100411git, I found that the whole NM package stack are agaist > naming guideline > See http://fedoraproject.org/wiki/PackageNamingGuidelines#Snapshot_packages Fixed. > 3. > BuildRequires: dbus-devel > BuildRequires: NetworkManager-devel > Fixed. > Those line can be commented out just for a reference, NetworkManager-glib-devel > already requires them. > > See http://koji.fedoraproject.org/koji/rpminfo?rpmID=1970296 The latest modified versions are available at http://people.redhat.com/~avagarwa/files/NetworkManager-openswan/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review