Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570017 --- Comment #6 from Laurent Rineau <laurent.rineau__fedora@xxxxxxxxxxxxxx> 2010-06-08 18:00:03 EDT --- Spec URL: http://www.rineau.fr/k4dirstat.spec SRPM URL: http://www.rineau.fr/k4dirstat-0-0.4.20100304gitec01dd42.fc13.src.rpm Changelog: * Tue Jun 8 2010 <Laurent.Rineau__fedora@xxxxxxxxxxxxxx> - 0-0.6.20100304gitec01dd42 - %%{_kde4_docdir}/HTML/en/k4dirstat/ must be owned. - use %%global instead of %%define * Tue Jun 8 2010 <Laurent.Rineau__fedora@xxxxxxxxxxxxxx> - 0-0.5.20100304gitec01dd42 - Fix the changelog (bad email and bad use of %%{?dist}). * Tue Jun 8 2010 <Laurent.Rineau__fedora@xxxxxxxxxxxxxx> - 0-0.4.20100304gitec01dd42 - Patch0 for F-13: link explicitly with zlib. - Add a comment on Source0. (In reply to comment #2) > Taking for review. > > Build for current rawhide fails with the following error: > /usr/bin/ld: CMakeFiles/k4dirstat.dir/kdirtreecache.o: undefined reference to > symbol 'gzclose' My machines now run F-13. I have been able to test the issue, and patched k4dirstat so that it links with zlib explicitly. > You might want to use globs in %files section to make the package easier to > maintain. It's entirely up to you, tough, if you want to use globs in there. > For example, > %{_kde4_iconsdir}/hicolor/16x16/apps/k4dirstat.png > %{_kde4_iconsdir}/hicolor/32x32/apps/k4dirstat.png > %{_kde4_iconsdir}/hicolor/48x48/apps/k4dirstat.png > > could be replaced by: > %{_kde4_iconsdir}/hicolor/*/apps/k4dirstat.png > > and > %{_kde4_docdir}/HTML/en/k4dirstat/common > %{_kde4_docdir}/HTML/en/k4dirstat/index.cache.bz2 > %{_kde4_docdir}/HTML/en/k4dirstat/index.docbook > > could be replaced by: > %{_kde4_docdir}/HTML/en/k4dirstat/* I prefer not to use globbing to much, to avoid surprises when I update the spec file with a new upstream version. Is it required by the guidelines to minimize the size of %file? Anyway, %{_kde4_docdir}/HTML/en/k4dirstat/ must be owned, and my previous %file did not own it. It is fixed now. As for the icons, I prefer to specify the files list. > Use %global instead of %define as per > https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define In this context, it is the same. But I agree that %global should be used blindly, unless the specific semantic of %define is wanted. Fixed. > > Source0: %{name}-%{preversion}.tar.gz > You'll need to add a comment how to generate the git snapshot tarball. See > https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control I have added such a comment. Strangely, the md5sum of the tarball has changed, but not its content. Maybe I used non-default compression level for gzip in March. Note that the upstream Git repository has not evolved since April, and the used Git revision is the same. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review