Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=601408 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-06-08 06:57:18 EDT --- Nice program... Review: Good: - name ok - license ok - group ok - no libs - no *.la - arch ok - BR ok - %prep ok - %build ok - $ rpmlint ./noarch/techtalk-pse-1.0.0-1.fc13.noarch.rpm ./techtalk-pse-1.0.0-1.fc13.src.rpm techtalk-pse.noarch: W: spelling-error %description -l en_US preloaded -> reloaded, p reloaded, freeloaded techtalk-pse.src: W: spelling-error %description -l en_US preloaded -> reloaded, p reloaded, freeloaded 2 packages and 0 specfiles checked; 0 errors, 2 warnings. - builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2237781 Needswork: - better use %{version} in URL - could you please use INSTALL="install -p" when installing? - please include the example in %doc, I didn't found a good starting point online, except the man page an this one example ############################################################################# The issues are all SHOULD. ############################################################################# APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review