Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: espeak - Software speech synthesizer (text-to-speech) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209311 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-11-03 10:45 EST ------- Well, a lot of improvements!! The left things are: 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Use rpmlint - Now -debuginfo rpm is correctly created, however, this package (-debuginfo) bears lots of complaint, e.g. E: espeak-debuginfo script-without-shebang \ /usr/src/debug/espeak-1.16-source/src/sintab.h This is due to incorrect permission. Please change this to 0644. 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : (= Nothing). 3. Other things I have noticed : * Well, I recommend changing suffix for different patches. * It seems that makefile_rpmoptflags.patch is not necessary, which can be replaced with: make %{?_smp_mflags} BIN_NAME=espeak CXXFLAGS=${RPM_OPT_FLAGS} * The original files .orig files e.g. /usr/share/doc/espeak-1.16/html/add_language.html.orig are not necessary. = Well, * the license issue of binary voice data * file list of -devel package are okay. -------------------------------------------------------------- Please fix above. After that, I will accept this package and sponsor you. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review