Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=601160 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-06-07 15:04:29 EDT --- Some initial notes: * %define -> %global - Now we prefer to use %global instead of %define: https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define * debuginfo rpm - Please don't set "%define debug_package %{nil}" and create debuginfo rpm correctly * License - As far as I checked the source codes, the license tag should be "ASL 1.1". * ruby(abi) dependency - For ruby module packages, writing "R: ruby(abi) = 1.8" is mandatory on Fedora: https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines * BuildRoot no longer needed - For Fedora (not for EPEL), BuildRoot tag is no longer needed: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * redundant "exit 0" - You needed not redundant "exit 0" at the end of %prep, %build, %install (not: %prep, %build, %install stage execute shell script with "/bin/sh -e") * Some generic packaging issue for rubygems containing C extension modules - Arch-dependent files (like rdiscount.so) must be moved to under %ruby_sitearch: https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_packages_with_binary_content.2Fshared_libraries - Files under ext/ directory (and ext/ directory itself) are needed to generate C extension module file and should not be needed on runtime. i.e. ext/ directory should not be in generated binary rpm. * Marking files as %doc - Please mark document files as %doc properly - (COPYING and) README.markdown Rakefile should be marked as %doc ( note that Rakefile is something like makefiles in autotool based packages ) - man/ test/ directories should also be marked as %doc - Also I usually suggest to create -doc subpackage and move * Rakefile * man/ test/ directories * %{gemdir}/doc/%{gemname}-%{version} to -doc subpackage - By the way * I think rdiscount.1 man file should be moved to %_mandir/man1 * I am not sure if markfile.7 should also be moved to %_mandir/man7 or not. * Duplicate %files entry - Please make it sure that every file/directory/etc is listed only once in %files entry. Currently build.log shows: ------------------------------------------------------------------------- 164 Processing files: rubygem-rdiscount-1.6.3.2-1.fc14.i686 165 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/rdiscount-1.6.3.2/COPYING ------------------------------------------------------------------------- * Enabling test - As this gem contains test/ directory, please add %check section and execute some test program (like $ rake test) there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review