Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=601038 --- Comment #1 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-06-07 13:07:59 EDT --- Looks good! koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2234597 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Latest version (0.101340) is being packaged. Source tarballs match upstream (sha1sum): fcab64093599e78d221d94173a5b4a1754a6a83d MooseX-Types-Perl-0.101340.tar.gz fcab64093599e78d221d94173a5b4a1754a6a83d MooseX-Types-Perl-0.101340.tar.gz.srpm Final provides / requires are sane: ====> rpmlint perl-MooseX-Types-Perl.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. ======> perl-MooseX-Types-Perl-0.101340-1.fc14.noarch.rpm <====== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides perl(MooseX::Types::Perl) = 0.101340 perl-MooseX-Types-Perl = 0.101340-1.fc14 ====> requires perl(:MODULE_COMPAT_5.12.0) perl(MooseX::Types) perl(MooseX::Types::Moose) perl(Params::Util) perl(version) >= 0.82 ====> obsoletes ====> conflicts ======> perl-MooseX-Types-Perl-0.101340-1.fc14.src.rpm <====== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides ====> requires perl(ExtUtils::MakeMaker) perl(MooseX::Types) perl(MooseX::Types::Moose) perl(Params::Util) perl(Test::More) perl(version) >= 0.82 ====> obsoletes ====> conflicts APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review