Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=580447 --- Comment #8 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-06-07 12:51:14 EDT --- The perl_default_filter macro needs to be invoked as %{?perl_default_filter}, and needs to be invoked right before the first %description section, to avoid any possible scriptlet contamination. I don't think TEST_MB_EXPERIMENTAL should be set, but it's your call -- and if you do want it set, to be effective it should be set in the %check section. Update for the above, and I'll approve :) koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2236371 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Latest version (0.3607) is being packaged. Source tarballs match upstream (sha1sum): dde7a241bc1e4ede2497e25a4253833dc7d95469 Module-Build-0.3607.tar.gz dde7a241bc1e4ede2497e25a4253833dc7d95469 Module-Build-0.3607.tar.gz.srpm Final provides / requires are sane: ====> rpmlint perl-Module-Build.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. ======> perl-Module-Build-0.3607-1.fc14.noarch.rpm <====== ====> rpmlint perl-Module-Build.noarch: W: spelling-error %description -l en_US subclassing -> sub classing, sub-classing, subclass 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides perl(Module::Build) = 0.3607 perl(Module::Build::Base) = 0.3607 perl(Module::Build::Compat) = 0.3607 perl(Module::Build::Config) = 0.3607 perl(Module::Build::ConfigData) perl(Module::Build::Cookbook) = 0.3607 perl(Module::Build::Dumper) = 0.3607 perl(Module::Build::ModuleInfo) = 0.3607 perl(Module::Build::Notes) = 0.3607 perl(Module::Build::PPMMaker) = 0.3607 perl(Module::Build::Platform::Amiga) = 0.3607 perl(Module::Build::Platform::Default) = 0.3607 perl(Module::Build::Platform::EBCDIC) = 0.3607 perl(Module::Build::Platform::MPEiX) = 0.3607 perl(Module::Build::Platform::MacOS) = 0.3607 perl(Module::Build::Platform::RiscOS) = 0.3607 perl(Module::Build::Platform::Unix) = 0.3607 perl(Module::Build::Platform::VMS) = 0.3607 perl(Module::Build::Platform::VOS) = 0.3607 perl(Module::Build::Platform::Windows) = 0.3607 perl(Module::Build::Platform::aix) = 0.3607 perl(Module::Build::Platform::cygwin) = 0.3607 perl(Module::Build::Platform::darwin) = 0.3607 perl(Module::Build::Platform::os2) = 0.3607 perl(Module::Build::PodParser) = 0.3607 perl(Module::Build::Version) = 0.77 perl(Module::Build::YAML) = 1.40 perl(inc::latest) = 0.3607 perl(inc::latest::private) = 0.3607 perl-Module-Build = 0.3607-1.fc14 ====> requires /usr/bin/perl perl(:MODULE_COMPAT_5.10.1) perl(Carp) perl(Config) perl(Cwd) perl(Data::Dumper) perl(ExtUtils::CBuilder) >= 0.27 perl(ExtUtils::Install) perl(ExtUtils::Install) >= 0.3 perl(ExtUtils::MakeMaker) perl(ExtUtils::Manifest) >= 1.54 perl(ExtUtils::Mkbootstrap) perl(ExtUtils::ParseXS) >= 2.21 perl(File::Basename) perl(File::Compare) perl(File::Copy) perl(File::Find) perl(File::Path) perl(File::Spec) perl(Getopt::Long) perl(IO::File) perl(Module::Build) perl(Module::Build) >= 0.25 perl(Module::Build::Base) perl(Module::Build::Compat) >= 0.02 perl(Module::Build::Config) perl(Module::Build::Dumper) perl(Module::Build::ModuleInfo) perl(Module::Build::Notes) perl(Module::Build::Platform::Unix) perl(Module::Build::Version) perl(Text::ParseWords) perl(inc::latest::private) perl(strict) perl(vars) perl(version) >= 0.74 ====> obsoletes ====> conflicts ======> perl-Module-Build-0.3607-1.fc14.src.rpm <====== ====> rpmlint perl-Module-Build.src: W: spelling-error %description -l en_US subclassing -> sub classing, sub-classing, subclass 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides ====> requires perl(Archive::Tar) perl(ExtUtils::CBuilder) >= 0.27 perl(ExtUtils::Install) >= 0.3 perl(ExtUtils::Manifest) >= 1.54 perl(ExtUtils::Mkbootstrap) perl(ExtUtils::ParseXS) >= 2.21 perl(Module::Signature) perl(PAR::Dist) perl(Pod::Readme) perl(Software::License) perl(Test::Harness) >= 3.16 perl(Test::More) >= 0.49 perl(version) >= 0.74 ====> obsoletes ====> conflicts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review