Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #47 from Thibault North <thibault.north@xxxxxxxxx> 2010-06-07 10:29:09 EDT --- Hi, I've just tried that SPEC and it looks good. TODO, imho : - Please just remove the commented lines (macro could be interpreted anyways; ok that shouldn't be a problem in that spec.) - I guess josm-generate-tarball.sh should be 0755. - The file /usr/share/doc/josm-0/CONTRIBUTION should be fixed using sed -ie 's/\r//g' CONTRIBUTION Glad to see this package being included ! Here is the related rpmlint output : [tnorth@grouchy tmp]$ rpmlint /home/tnorth/rpmbuild/SRPMS/josm-0-0.2.3208svn.fc12.src.rpm josm.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsus josm.src: W: strange-permission josm-generate-tarball.sh 0744 josm.src:20: W: macro-in-comment %{name} josm.src:20: W: macro-in-comment %{svn_revision} josm.src:110: W: macro-in-comment %{buildroot} josm.src:110: W: macro-in-comment %{_bindir} josm.src:111: W: macro-in-comment %SOURCE1 josm.src:111: W: macro-in-comment %{buildroot} josm.src:111: W: macro-in-comment %{_bindir} josm.src:111: W: macro-in-comment %{name} josm.src:112: W: macro-in-comment %{buildroot} josm.src:112: W: macro-in-comment %{_bindir} josm.src:112: W: macro-in-comment %{name} josm.src:118: W: macro-in-comment %{buildroot} josm.src:118: W: macro-in-comment %{_mandir} josm.src:119: W: macro-in-comment %SOURCE4 josm.src:119: W: macro-in-comment %{buildroot} josm.src:119: W: macro-in-comment %{_mandir} josm.src:120: W: macro-in-comment %{buildroot} josm.src:120: W: macro-in-comment %{_mandir} josm.src:120: W: macro-in-comment %{name} josm.src: W: invalid-url Source0: josm-0.3208svn.tar.gz 1 packages and 0 specfiles checked; 0 errors, 22 warnings. [tnorth@grouchy tmp]$ rpmlint /home/tnorth/rpmbuild/RPMS/noarch/josm-0-0.2.3208svn.fc12.noarch.rpm josm.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsus josm.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/josm-0/CONTRIBUTION josm.noarch: W: file-not-utf8 /usr/share/doc/josm-0/CONTRIBUTION 1 packages and 0 specfiles checked; 0 errors, 3 warnings. [tnorth@grouchy tmp]$ rpmlint /home/tnorth/rpmbuild/RPMS/noarch/josm-javadoc-0-0.2.3208svn.fc12.noarch.rpm josm-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Javanese 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review