Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549296 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|530636(Python3F13) | Flag|fedora-review? |fedora-review+ --- Comment #6 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-06-06 13:19:31 EDT --- I don't see anything about python2 only or python3, but ok. So here is the review: Good: - macros everywhere - name/version ok - group ok - arch: noarch ok - %prep ok - %build ok - %install ok - %clean there - buildroot ok - license ok - no libs - no *.la - requires look ok (none) Needswork: - $ rpmlint -I non-conffile-in-etc non-conffile-in-etc: A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. - too much BR: setuptools is not needed, because the egg is build with distuils (buils in koji without setuptools: http://koji.fedoraproject.org/koji/taskinfo?taskID=2233657) ############################################################################## Not much todo... ############################################################################## APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review