[Bug 599097] Review Request: libgexiv2 - Gexiv2 is a GObject-based wrapper around the Exiv2 library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599097

--- Comment #11 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-06-05 02:23:16 EDT ---
You can also remove the variable definitions (CFLAGS, CXXFLAGS, FFLAGS) from
the %build section. They are part of the %configure macro. 
However, since I obviously was too tired yesterday, I gave you a wrong
configure replacement (sorry for that!). The Makefile doesn't recognize the
locally set variables. It should work with a %build section that looks like
this:

echo '%{configure}' | sed '/--program-prefix=/d' >build.tmp
echo 'make %{?_smp_mflags}' >>build.tmp
sh build.tmp


Since there are no empty files in the buildroot, you should really remove the
redundant for loop. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]