Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ibmasm https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193059 ------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx 2006-11-03 03:14 EST ------- Builds fine in mock, rpmlint is quiet. Full review time Spec file clear, in US English License is good and the exclusivearch is commented - you will need to add a blocked on 64 bit architectures though via bugzilla Consistent use of macros Init scripts correctly used pre/post scripts look good Builds cleanly in mock rpmlint quiet includes devel file, no pc file so no pkg-config required devel package contains the correct information documentation include (though not for the devel package - this is okay) Needs work -devel needs the line %{_includedir}/ibmasm/*.h changing to %{_includedir}/ibmasm otherwise you the package won't own the directory -permissions should be the same for both packages Do these changes and I'm happy. You will still need a sponsor before you can import this package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review