Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599097 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #9 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2010-06-04 15:33:17 EDT --- (In reply to comment #8) > - %{_includedir}/* is a bit too generic. Replace it with %{_includedir}/gexiv2/ I would say the same thing about %{_libdir}/*.so and %{_libdir}/*.so.* since I'd guess there is only one or a couple of libraries that are installed, so I usually recommend filling in these in more precision, e.g. %{_libdir}/libfoo.so and %{_libdir}/libfoo.so.* Also, I think -devel should Requires: vala for dir ownership, as there is a file put in %{_datadir}/vala/vapi/. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review