[Bug 596449] Review Request: NetworkManager-openswan - NetworkManager VPN plugin for Openswan (IPsec)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596449

--- Comment #20 from Chen Lei <supercyper1@xxxxxxxxx> 2010-06-04 12:40:50 EDT ---

Rpm building fails on koji. I think you should remove the icon file, because
you don't include a desktop file in rpm, also other NM plugins already remove
icons and desktop files recently.

error: Installed (but unpackaged) file(s) found:
  
/usr/share/icons/hicolor/48x48/apps/gnome-mime-application-x-openswan-ipsec-vpn-settings.png



formal review here:
+:ok, =:needs attention, -:needs fixing

MUST Items:
[-] MUST: rpmlint must be run on every package.
rpmlint NetworkManager-openswan.spec 
NetworkManager-openswan.spec:31: W: mixed-use-of-spaces-and-tabs (spaces: line
7, tab: line 31)

rpmlint NetworkManager-openswan-*rpm
NetworkManager-openswan.x86_64: I: enchant-dictionary-not-found en_US
NetworkManager-openswan.x86_64: W: incoherent-version-in-changelog 0.8.0-1
['0.8.0-1.git20100411.fc14', '0.8.0-1.git20100411']
NetworkManager-openswan.x86_64: W: non-conffile-in-etc
/etc/NetworkManager/VPN/nm-openswan-service.name
NetworkManager-openswan.x86_64: W: non-conffile-in-etc
/etc/dbus-1/system.d/nm-openswan-service.conf

[-] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[+] MUST: The package must meet the Packaging Guidelines. [FIXME?: covers this
list and more]
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
<<md5sum checksum>>065b8f38d89e7bc40bfe0d15a9e7f8ba
[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[=] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro.
[+] MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[+] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[=] SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[+] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.

Issues:

1. Most of the rpmlist warnings are harmless.
You should fix 
NetworkManager-openswan.spec:31: W: mixed-use-of-spaces-and-tabs (spaces: line
7, tab: line 31)

NetworkManager-openswan.x86_64: W: incoherent-version-in-changelog 0.8.0-1
['0.8.0-1.git20100411.fc14', '0.8.0-1.git20100411']


2.According to naming guideline %define snapshot .git20100411 should be %define
snapshot .20100411git, I found that the whole NM package stack are agaist
naming guideline
See http://fedoraproject.org/wiki/PackageNamingGuidelines#Snapshot_packages
3.
BuildRequires: dbus-devel
BuildRequires: NetworkManager-devel

Those line can be commented out just for a reference, NetworkManager-glib-devel
already requires them.

See http://koji.fedoraproject.org/koji/rpminfo?rpmID=1970296

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]