Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598902 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2010-06-03 14:49:18 EDT --- This is a package review, not a merge review ;) $ rpmlint pxz-* pxz.x86_64: W: incoherent-version-in-changelog 4.999.9-0.1.20100603.beta ['4.999.9-0.1.beta.20100603git.fc13', '4.999.9-0.1.beta.20100603git'] 3 packages and 0 specfiles checked; 0 errors, 1 warnings. so the change log EVR entries should be of the style 4.999.9-0.1.beta.20100603git not 4.999.9-0.1.20100603.beta - I abhor wildcards where they are not needed. Please change %{_mandir}/man1/*.1* to %{_mandir}/man1/pxz.1* - Please change URL to http://jnovy.fedorapeople.org/pxz as that's a *lot* easier to paste from the spec file. Otherwise, my earlier comments seem to have been taken into account. One final comment: now the compilation does not use the "-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE" flags. Are these not necessary on Fedora? The final changes are cosmetic, so you can consider this package APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review