Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599324 --- Comment #3 from Tareq Al Jurf <taljurf@xxxxxxxxxxxxxxxxx> 2010-06-03 12:42:24 EDT --- (In reply to comment #2) > Hi Tareq, here are some quick comments: > > - the license seems to be GPLv2+ (according to the source headers) > - use %{version} in Source0 to simplify future package updates > - COPYING is missing in %doc > - drop empty file NEWS from %doc > > > $ rpmlint /var/lib/mock/fedora-13-i386/result/*.rpm > rotoscope.i686: W: name-repeated-in-summary C rotoscope > rotoscope.i686: W: spelling-error %description -l en_US rotoscoping -> > arthroscopic, stroboscopic, gyroscopic > rotoscope.i686: E: zero-length /usr/share/doc/rotoscope-0.2/NEWS > rotoscope.src: W: name-repeated-in-summary C rotoscope > rotoscope.src: W: spelling-error %description -l en_US rotoscoping -> > arthroscopic, stroboscopic, gyroscopic > 3 packages and 0 specfiles checked; 1 errors, 4 warnings. Thx martin, *First warning fixed. *Second warning could be ignored since rotoscoping is a word http://en.wikipedia.org/wiki/Rotoscoping *Error fixed Spec URL: http://taljurf.fedorapeople.org/Packages/i686/rotoscope/rotoscope.spec SRPM URL: http://taljurf.fedorapeople.org/Packages/i686/rotoscope/rotoscope-0.2-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review