Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578024 --- Comment #20 from Jay Hankinson <jeremy.hankinson@xxxxxxxxxx> 2010-06-02 19:22:02 EDT --- (In reply to comment #19) > (In reply to comment #17) > > (In reply to comment #15) > > Apologies for the radio silence, I got pulled onto another project for a couple > > of weeks. Thanks for your update, hopefully I can make some progress now. > > > Some easy fix issues: > > > 1.Those lines should be removed from spec > > > # Requries changes from upstream but can be supported > > > ExcludeArch: ia64 > > > # Not officially supported by upstream, but possible with some tweaking > > > ExcludeArch: ppc > > > # As ppc > > > ExcludeArch: ppc64 > > > # Unsupported by upstream (although was previously) > > > ExcludeArch: S390 > > > # Unsupported by upstream > > > ExcludeArch: ARM > > > # Unsupported by upstream > > > ExcludeArch: Parisc > > > # Unsupported by upstream > > > ExcludeArch: SPARC > > > Requires: %{_bindir}/sed > > > Requires: %{_bindir}/grep > > > Requires: /sbin/runuser > > > Requires: %{__tar} > > > Requires: %{_bindir}/ipcs > > > Requires: %{__awk} > > Sure, although I added the ExcludeArch entries because of notes in standards. > > When _do_ you use ExcludeArch > > IMHO the ExcludeArch lines are ok. They are used by the secondary arch SIGs. > But I am not sure about the values, iirc it's s390 not S390, but maybe this > does not matter. Also the Requires do in general make sense, if they are really > needed. But package names instead of the paths are better, e.g. grep is in > /bin/grep and not in /usr/bin/grep, unless the paths are hardcoded. But then > the package won't work. I'll pull them all out for now. If we need them I can re-add them later, I'd rather keep things as clean as possible. > > > > > 4.%defattr(-,ingres,ingres,-) should always be %defattr(-,root,root,-) > > Even if the vast majority of the files are owned by 'ingres'? > > I guess it is ok in this case, but it is better to ask on the fedora packaging > list. Btw. the spec seems to be gone currently, therefore I did not take a look > at it. OK, thanks. Good to know. It seems the spec file and SRPM have fallen victim to a purging process on our FTP server. I'll re-post with the changes, I've requested my staging directory be excluded from the purge. Hopefully this won't happen again. Thanks for your help, Jay -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review