Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578024 --- Comment #18 from Jay Hankinson <jeremy.hankinson@xxxxxxxxxx> 2010-06-02 18:51:10 EDT --- (In reply to comment #16) > 1.%package documentation should be %package doc and should noarch. OK > 2. Conflicts: ingres > When possible, rpm should be avoid of using conflicts The problem is, it DOES conflict with ingres. We've had Ingres available as RPMs for a number of years but they don't conform to the standards. Installing both could lead to unpredictable behavior on both side and I'd rather keep that from occurring if I can. > 3.List files explicit rather than %file -f Unless it's absolutely necessary, I'd rather not maintain file lists in the SPEC file separately. There are over 1700 files between the 4 RPMs and the ownership and permission for each file is maintained by one of the build tools. In order to add the file lists to the SPEC files, I would need to do full build of the exact same source outside of RPM, generate the files list, add them to SPEC file and then run the RPM build. This is a fairly large over head for each update and makes maintenance a much larger task. By using the -f flag, I can generate the lists at build time using the existing manifest and they will always be correct. I'll make the other updates suggested and re-post. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review