Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594844 --- Comment #5 from Ville Skyttä <ville.skytta@xxxxxx> 2010-06-02 02:02:22 EDT --- Created an attachment (id=418918) --> (https://bugzilla.redhat.com/attachment.cgi?id=418918) Fix test suite exit status on failure (In reply to comment #3) > And patching of upstream build process/test scripts is needed; if tests fail, > the test suite and build should fail too. Looks like this part is not addressed yet. Something like the attached patch should do the trick (I just sent the patch upstream too). Other remaining issues: %configure and the rpath seds should be done in %build, not %prep. Version in %changelog's entry for 0.2.4-4 is wrong (0.2.4-3). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review