Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598138 --- Comment #5 from Shreyank Gupta <sgupta@xxxxxxxxxx> 2010-06-01 04:55:51 EDT --- Updated: -------- Spec URL: http://shreyankg.fedorapeople.org/packaging/rmail/rubygem-rmail.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/rmail/rubygem-rmail-1.0.0-2.fc13.src.rpm Notes: ------ Along with your suggestions I have made the following other updates: * BuildRequires: ruby * Added rake test - thus I have kept the data.17 file intact. I could have removed it after rake tests, but did not. Although I get the following error with rpmlint: rubygem-rmail-doc.noarch: E: zero-length /usr/lib/ruby/gems/1.8/gems/rmail-1.0.0/test/data/multipart/data.17 * In the separate -doc subpackage I have added /doc NEWS NOTES THANKS TODO alongwith, guide/ test/ Rakefile as I think those should be a part of the -doc subpackage as well. * I have deleted install.rb Koji Scratch build: ------------------- http://koji.fedoraproject.org/koji/taskinfo?taskID=2221764 P.S. Also should I do a scratch build everytime I update the specfile to the review request? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review