Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570731 --- Comment #17 from Peng Wu <pwu@xxxxxxxxxx> 2010-06-01 01:50:33 EDT --- (In reply to comment #16) > Some initial comment > 1. > %{!?python_sitelib: %define python_sitelib %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print get_python_lib()")} > %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print get_python_lib(1)")} > > %define mod_path ibus-1.2 > %define zinnia_tomoe_version 0.6.0-20080911 > > It seems those macros are not used in spec? removed. > > 2.Patch0: ibus-handwrite-2.0.1-fixes-ibus-component-xml.patch > Is this patch specific to fedora? > Not specific. > 3. > BuildRequires: zinnia-devel zinnia-tomoe > ->BuildRequires: zinnia-devel > Requires: ibus gtk2 > -> ibus > merged. > 4. > %build > ./autogen.sh > You don't modify configure.ac or Makefile.am, this may be not needed. > commented out. > 5. > %files > %dir %{_datadir}/ibus-handwrite > %{_datadir}/ibus-handwrite/icons/ibus-handwrite.svg > %{_datadir}/ibus-handwrite/data/table.txt > -> > %files > %{_datadir}/ibus-handwrite > > You must own all directories in %{_datadir}/ibus-handwrite. > merged. > 6. > > BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) > > %install > rm -rf $RPM_BUILD_ROOT > > Those two line are only needed for EPEL5. removed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review