Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597709 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-05-31 14:19:22 EDT --- Some notes: Please also address the issue I wrote on bug 598138. Then: * Summary - Is "and ruby 1.9.1" part needed for Summary? (even if we move to ruby 1.9.x on F-14, I don't think this part is needed). * License - The license tag for this package should be "LGPLv2+". * Unneeded files - *.c, *.h files are for source files for C extension .so file, *.o binary files are used for generating the file. Also "extconf.rb" is like configure, and "mkmf.log" is like config.log. These files are not needed on runtime and should not be packaged into binary rpm. * Arch dependent binary file - C extension .so file is arch-dependent and must be moved to under %ruby_sitearch https://fedoraproject.org/wiki/Packaging/Ruby#Build_Architecture_and_File_Placement -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review