Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593851 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-05-31 12:42:40 EDT --- Hi Richard, here are a couple of quick comments: - according to COPYING and the script header, the license seems to be GPLv3+, not GPLv2+ - drop LICENSE from %doc and ask upstream to remove it from the tarball, as it refers to GPLv2 - add a short comment above Patch0 telling what the patch does - prefix the patch name with clide-, e.g. clide-makefile.patch - The manpage should not be compressed by the installer because rpm does it automatically. Thus, remove the gzip line from the Makefile - replace %{_mandir}/man1/clide.1.gz with %{_mandir}/man1/clide.1* -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review