Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598138 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-05-31 12:48:28 EDT --- Some notes: * Unneeded macros - Explicitly defined %ruby_sitelib is used nowhere. * Unused macros - As %geminstdir is explicitly defined, please use it also in %files. * ruby(abi) dependency - "R: ruby(abi) = 1.8" should be written: https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines * Documents - Please mark document files as %doc appropriately - The following files / directories should be marked as %doc: NEWS NOTES README Rakefile (as this is similar to "Makefile" for autotools system) THANKS TODO guide/ install.rb (rather remove this) test/ And I suggest to create -doc subpackage and move Rakefile guide/ test/ to -doc subpackage. ! Note that when marking these files as %doc, please take care that duplicate %files entry won't appear. * Enabling tests - As this gem contains test/ directory, please add %check section and execute some test program (rake test) there. ! Note Please check if zero-size files can really be removed. Actually for this package "rake test" fails if zero-size file test/data/multipart/data.17 is removed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review