Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598058 --- Comment #3 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2010-05-31 08:05:49 EDT --- Before I start official review process I have few things: * use global instead of define macro * there is already version 1.0 (do `svn ls http://svn.apache.org/repos/asf/maven/plugins/tags/ | grep docck` and you'll see) * check http://maven.apache.org/plugins/maven-docck-plugin/dependencies.html for docck plugin dependencies. You are missing at least a few (commons-logging, commons-httpclient comes to mind). Or perhaps this and other dependencies are optional? Either way, this needs to be either fixed or explained * version in changelog is incomplete? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review