Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=546738 Matthias Clasen <mclasen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mclasen@xxxxxxxxxx --- Comment #3 from Matthias Clasen <mclasen@xxxxxxxxxx> 2010-05-29 20:19:49 EDT --- package name: ok spec file name: ok packaging guidelines: - the rm -rf at the top of %install is no longer necessary - %clean is no longer necessary - the handling of the icon cache should be updated to follow https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - the desktop file has no MimeType entry, so the update-desktop-database call is unnecessary license: ok license field: ok license file: ok spec file language: ok spec file readability: ok upstream sources: ok buildable: ok excludearch: ok buildrequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: ok directory ownership: ok duplicate files: ok permissions: ok macro use: ok permissable content: ok large docs: ok %doc content: ok headers: ok static libs: ok shared libs: ok devel package: ok libtool archives: ok gui app: - need to call desktop-file-validate on the installed desktop file directory ownership: ok utf8 filenames: ok -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review