Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=580447 Chris Weyl <cweyl@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-05-29 17:57:01 EDT --- There's a couple things going on here: In %files, we need to use %{perl_privlib} rather than %{perl_vendorlib} (as this is duallifed/core). I'd feel a touch better if we invoked %{perl_default_filter}, but it's not strictly required. :) While we don't need to do this for the subpackage, for this independent package we should BR the extra bits to fully exercise the test suite (except for the scary bits marked "EXPERIMENTAL"): perl(PAR::Dist) perl(Archive::Tar) I didn't check the "TEST_SIGNATURE" parts, but if it works sanely in the buildsys (might not if it needs, say, network access to keyservers or somesuch) we should enable it as well. A newer version has been released; normally I wouldn't consider this a blocker for you, but as long as we're making these other changes... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review