Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592864 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-05-29 12:59:54 EDT --- Well, this package "builds" at least on F-14 and F-13. Some comments from me - For sourceforge hosted packages, please check https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net - Some BuildRequires are redundant. For example, zlib-devel always require zlib, so with "BR: zlib-devel", "BR: zlib" is not needed. Also kdelibs3-devel requires qt3-devel, so BR: qt3-devel is redundant. - For Fedora BuildRoot tag is no longer needed (EPEL build still needs this) https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag - Please explain why you restrict BuildArch to i686. If build really fails on x86_64 please try to fix it. - Currently Fedora specific compilation flags are not honored and generated debuginfo rpm is incomplete. Please make it sure that Fedora specific compilation flags are honored correctly. https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags - There are some %files list mistakes on directory ownership issue. For example, the directory %{_datadir}/apps/%{name}/ itself is not owned by any packages. Please check the following wiki page and make it sure that all directories which are created newly by installing this pacakges are owned by this package: https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes ! Note This package need not own the directory %{_datadir}/icons/ directories or so themselves, so %files entry ------------------------------------------------------------------ %{_datadir}/icons/hicolor/16x16/apps/%{name}.png %{_datadir}/icons/hicolor/22x22/apps/%{name}.png ..... ------------------------------------------------------------------ are correct (however using wildcard will make this part more readable) - It seems that files under %{_datadir}/icons/Locolor should be moved to under {_datadir}/icons/locolor (the latter directory is owned by kde-filesystem) - "make clean" in %clean stage is unneeded as the directory where tarball is expanded is anyway deleted. Also on Fedora 13 and above, writing %clean section is completely unneeded: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean - Usually "INSTALL" file is for people trying to compile and install softwares by themselves and not needed for people using rpm (or other package manager) - The rebuilt binary contains rpaths (you can check this by using "rpmlint" command (in rpmlint rpm). Please check your srpm / rebuilt binary rpms / installed rpm by rpmlint). ------------------------------------------------------------------- kmyfirewall.i686: E: binary-or-shlib-defines-rpath /usr/lib/libkmfcore.so.0.0.0 ['/usr/lib', '/usr/lib/qt-3.3/lib'] kmyfirewall.i686: E: binary-or-shlib-defines-rpath /usr/lib/kde3/libkmfruletargetoptionedit_tos.so ['/usr/lib', '/usr/lib/qt-3.3/lib'] kmyfirewall.i686: E: binary-or-shlib-defines-rpath /usr/bin/kmyfirewall ['/usr/lib', '/usr/lib/qt-3.3/lib'] kmyfirewall.i686: E: binary-or-shlib-defines-rpath /usr/lib/kde3/libkmfruleoptionedit_mac.so ['/usr/lib', '/usr/lib/qt-3.3/lib'] ...... ------------------------------------------------------------------- And this type of rpaths are not allowed on Fedora. Please remove rpaths on these binaries: https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath Note using "chrpath" binary for removing rpaths must be regarded as a "last resort". - Please explain why header files under %_includedir/%name are needed for runtime. These files are usually needed only for building software and are not needed for runtime. https://fedoraproject.org/wiki/Packaging/Guidelines#Devel_Packages Also %_libdir/libkmfwidgets.so is usually for development files and not needed for runtime. - .la libtool files or .a static archives should be removed unless some reason exists: https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries - Files under %_syscondir should usually be marked as %config(noreplace), ref: https://fedoraproject.org/wiki/Packaging/Guidelines#Configuration_files - Please include some needed scriptlets - /sbin/ldconfig must be called for %_libdir/lib***.so.* : https://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries - GTK icon cache must be updated: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache - As the desktop under %_datadir/applications/kde contains Mimetype key, desktop database must be updated: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review